Changeset 1656

Show
Ignore:
Timestamp:
09/02/06 22:07:10
Author:
miyagawa
Message:
  • Updated captured variable name to $warnings.
  • Fixed POD bug in Publish::Takahashi
  • Updated ID of Publish::Takahashi test to use MD5 of file path, since it depends on local path, Eh.
  • Added failing test for Planet XSS bug
Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/plagger/deps/Publish-Takahashi.yaml

    r1651 r1656  
    1 name: Publish::PowerTakahashi 
     1name: Publish::Takahashi 
     2author: Tatsuhiko Miyagawa 
     3 

  • trunk/plagger/lib/Plagger/Plugin/Publish/Takahashi.pm

    r1653 r1656  
    43431; 
    4444 
    45 =head11 NAME 
     45=head1 NAME 
    4646 
    4747Plagger::Plugin::Publish::Takahashi - produce takahasi output 
    …… 
    5252    config: 
    5353      dir: /home/miyagawa/takahashi 
    54    
     54 
    5555=head1 DESCRIPTION 
    5656 

  • trunk/plagger/t/TestPlagger.pm

    r1650 r1656  
    231231        # this is often used in the tests as a way to find 
    232232        # out what has happened (e.g. the Growl plugin) 
    233         my $warning; 
     233        my $warnings; 
    234234        { 
    235             local $SIG{__WARN__} = sub { $warning .= "@_" }; 
     235            local $SIG{__WARN__} = sub { $warnings .= "@_" }; 
    236236            $block->run_filters; 
    237237        } 

  • trunk/plagger/t/core/assets_path.t

    r1418 r1656  
    2828  - module: Test::AssetsPath 
    2929--- expected 
    30 like $warning, qr!plugins[/\\]Test-AssetsPath!; 
     30like $warnings, qr!plugins[/\\]Test-AssetsPath!; 
    3131 
    3232=== Test plugin:assets_path 
    …… 
    3939      assets_path: $t::TestPlagger::BaseDir/t/samples 
    4040--- expected 
    41 unlike $warning, qr!/tmp/assets!; 
    42 like $warning, qr!assets_path is .*t/samples$!m; 
     41unlike $warnings, qr!/tmp/assets!; 
     42like $warnings, qr!assets_path is .*t/samples$!m; 
    4343 
    4444=== Test templatize 
    …… 
    5353  - module: Test::AssetsPath 
    5454--- expected 
    55 like $warning, qr/template: foo/; 
     55like $warnings, qr/template: foo/; 
    5656 
    5757=== Test localized templatize 
    …… 
    6666      assets_path: $t::TestPlagger::BaseDir/t/samples 
    6767--- expected 
    68 like $warning, qr/template: bar/; 
     68like $warnings, qr/template: bar/; 

  • trunk/plagger/t/core/log-level.t

    r1283 r1656  
    2828  - module: Test::Log 
    2929--- expected 
    30 like $warning, qr/error/; 
    31 like $warning, qr/info/; 
    32 like $warning, qr/warn/; 
    33 like $warning, qr/debug/; 
     30like $warnings, qr/error/; 
     31like $warnings, qr/info/; 
     32like $warnings, qr/warn/; 
     33like $warnings, qr/debug/; 
    3434 
    3535=== info log level 
    …… 
    4141  - module: Test::Log 
    4242--- expected 
    43 like $warning, qr/error/; 
    44 like $warning, qr/info/; 
    45 unlike $warning, qr/warn/; 
    46 unlike $warning, qr/debug/; 
     43like $warnings, qr/error/; 
     44like $warnings, qr/info/; 
     45unlike $warnings, qr/warn/; 
     46unlike $warnings, qr/debug/; 

  • trunk/plagger/t/plugins/Filter-FeedBurnerPermalink/feedburner.t

    r1283 r1656  
    2121  - module: Filter::FeedBurnerPermalink 
    2222--- expected 
    23 like $warning, qr/Permalink rewritten to/; 
     23like $warnings, qr/Permalink rewritten to/; 

  • trunk/plagger/t/plugins/Notify-Beep/beep.t

    r1483 r1656  
    2525  - module: Notify::Beep 
    2626--- expected 
    27 like $warning, qr/beep ok/; 
     27like $warnings, qr/beep ok/; 

  • trunk/plagger/t/plugins/Notify-Beep/music.t

    r1483 r1656  
    2727      music: "g' f bes' c8 f d4 c8 f d4 bes c g f2" 
    2828--- expected 
    29 like $warning, qr/g' f bes' c8 f d4 c8 f d4 bes c g f2/; 
     29like $warnings, qr/g' f bes' c8 f d4 c8 f d4 bes c g f2/; 

  • trunk/plagger/t/plugins/Notify-Eject/eject.t

    r1483 r1656  
    3131  - module: Notify::Eject 
    3232--- expected 
    33 like $warning, qr/eject ok/; 
     33like $warnings, qr/eject ok/; 
    3434 

  • trunk/plagger/t/plugins/Notify-Growl/growl.t

    r1533 r1656  
    3131  - module: Notify::Growl 
    3232--- expected 
    33 my @count = $warning =~ /^Growl: plagger:/gm; 
     33my @count = $warnings =~ /^Growl: plagger:/gm; 
    3434is scalar @count, 4; 
    3535 
    36 like $warning, qr{^Growl: plagger:Liftoff News:Star City:How do Americans }m; 
    37 like $warning, qr{^Growl: plagger:Liftoff News:The Engine That Does More:B}m; 
     36like $warnings, qr{^Growl: plagger:Liftoff News:Star City:How do Americans }m; 
     37like $warnings, qr{^Growl: plagger:Liftoff News:The Engine That Does More:B}m; 

  • trunk/plagger/t/plugins/Publish-Takahashi/publish.t

    r1651 r1656  
    33use t::TestPlagger; 
    44use File::Spec; 
     5use Digest::MD5 qw(md5_hex); 
    56 
    6 our $output = File::Spec->rel2abs("$FindBin::Bin/89c7ff2fc4bb5e80be21aa7cae83e2d1.xul"); 
     7our $url = "file://$t::TestPlagger::BaseDirURI/t/samples/rss-full.xml"; 
     8my $id = md5_hex($url); 
     9 
     10our $output = File::Spec->rel2abs("$FindBin::Bin/$id.xul"); 
    711our $css    = File::Spec->rel2abs("$FindBin::Bin/takahashi.css"); 
    812our $js     = File::Spec->rel2abs("$FindBin::Bin/takahashi.js"); 
    …… 
    2630    config: 
    2731      feed: 
    28         - file://$t::TestPlagger::BaseDirURI/t/samples/rss-full.xml 
     32        - $main::url 
    2933  - module: Publish::Takahashi 
    3034    config: 

  • trunk/plagger/t/plugins/UserAgent-AuthenRequest/authen.t

    r1283 r1656  
    1818        - http://irisresearch.library.cornell.edu/control/authBasic/authTest/ 
    1919--- expected 
    20 like $warning, qr/401 Authorization Required/; 
     20like $warnings, qr/401 Authorization Required/; 
    2121 
    2222=== With auth 
    …… 
    3737      password: this 
    3838--- expected 
    39 unlike $warning, qr/401 Authorization Required/; 
    40 like $warning, qr!200: http://irisresearch!; 
     39unlike $warnings, qr/401 Authorization Required/; 
     40like $warnings, qr!200: http://irisresearch!; 
    4141 
    4242=== With auth as list 
    …… 
    5858          password: this 
    5959--- expected 
    60 unlike $warning, qr/401 Authorization Required/; 
    61 like $warning, qr!200: http://irisresearch!; 
     60unlike $warnings, qr/401 Authorization Required/; 
     61like $warnings, qr!200: http://irisresearch!; 

  • trunk/plagger/t/regression/cookies-nofile.t

    r1312 r1656  
    2323open my $fh, "/tmp/xxxxxxxx"; 
    2424my $no_such_file = $!; 
    25 like $warning, qr/Cookies\.plist: $no_such_file/ 
     25like $warnings, qr/Cookies\.plist: $no_such_file/ 
    2626