Changeset 1588
- Timestamp:
- 08/24/06 19:14:33
- Files:
-
- trunk/plagger/lib/Plagger.pm (modified) (2 diffs)
- trunk/plagger/lib/Plagger/Plugin/Filter/EntryFullText.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Filter/FindEnclosures.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Filter/HEADEnclosureMetadata.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Filter/StripRSSAd.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Publish/CHTML.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Publish/Pipe.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Subscription/Bookmarks/InternetExplorer.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Subscription/Bookmarks/Mozilla.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Plugin/Subscription/Bookmarks/Safari.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Rule/Always.pm (modified) (1 diff)
- trunk/plagger/lib/Plagger/Walker.pm (modified) (1 diff)
- trunk/plagger/t/99-perlcritic.t (added)
- trunk/plagger/t/perlcriticrc (added)
Legend:
- Unmodified
- Added
- Removed
- Modified
- Copied
- Moved
trunk/plagger/lib/Plagger.pm
r1585 r1588 91 91 } 92 92 93 open my $fh, $self->{config_path} or $self->error("$self->{config_path}: $!");93 open my $fh, '<', $self->{config_path} or $self->error("$self->{config_path}: $!"); 94 94 my $data = join '', <$fh>; 95 95 close $fh; … … 187 187 my($self, $file) = @_; 188 188 189 open my $fh, $file or die "$file: $!";189 open my $fh, '<', $file or die "$file: $!"; 190 190 while (<$fh>) { 191 191 /^package (Plagger::Plugin::.*?);/ and return $1; trunk/plagger/lib/Plagger/Plugin/Filter/EntryFullText.pm
r1537 r1588 57 57 my($self, $file, $base) = @_; 58 58 59 open my $fh, $file or Plagger->context->error("$file: $!");59 open my $fh, '<', $file or Plagger->context->error("$file: $!"); 60 60 (my $pkg = $base) =~ s/\.pl$//; 61 61 my $plugin_class = "Plagger::Plugin::Filter::EntryFullText::Site::$pkg"; trunk/plagger/lib/Plagger/Plugin/Filter/FindEnclosures.pm
r936 r1588 53 53 my($self, $file, $base) = @_; 54 54 55 open my $fh, $file or Plagger->context->error("$file: $!");55 open my $fh, '<', $file or Plagger->context->error("$file: $!"); 56 56 (my $pkg = $base) =~ s/\.pl$//; 57 57 my $plugin_class = "Plagger::Plugin::Filter::FindEnclosures::Site::$pkg"; trunk/plagger/lib/Plagger/Plugin/Filter/HEADEnclosureMetadata.pm
r1505 r1588 71 71 my($res, $header) = @_; 72 72 73 my $value = $res->header($header) or return undef; 73 my $value = $res->header($header) or return undef; ## no critic 74 74 $value =~ s/;.*?$//; 75 75 $value; trunk/plagger/lib/Plagger/Plugin/Filter/StripRSSAd.pm
r758 r1588 38 38 my($self, $file, $base) = @_; 39 39 40 open my $fh, $file or Plagger->context->error("$file: $!");40 open my $fh, '<', $file or Plagger->context->error("$file: $!"); 41 41 my $re = join '', <$fh>; 42 42 chomp($re); trunk/plagger/lib/Plagger/Plugin/Publish/CHTML.pm
r1454 r1588 121 121 my $earlier; 122 122 my $file = "$path/earlier"; 123 if (open my $in, $file) {123 if (open my $in, '<', $file) { 124 124 $earlier = <$in>; 125 125 close $in; 126 126 } 127 open my $out, "> $file"or $self->context->error("$file: $!");127 open my $out, ">", $file or $self->context->error("$file: $!"); 128 128 print $out $self->id; 129 129 close $out; trunk/plagger/lib/Plagger/Plugin/Publish/Pipe.pm
r246 r1588 15 15 sub feed { 16 16 my($self, $context, $args) = @_; 17 18 open my $out, "|" . $self->conf->{command} or $context->error("Can't open pipe: $!"); 17 18 open my $out, "|" . $self->conf->{command} or $context->error("Can't open pipe: $!"); ## no critic 19 19 $context->log(info => "Publishing to " . $self->conf->{command}); 20 20 for my $entry ($args->{feed}->entries) { trunk/plagger/lib/Plagger/Plugin/Subscription/Bookmarks/InternetExplorer.pm
r994 r1588 1 1 package Plagger::Plugin::Subscription::Bookmarks::InternetExplorer; 2 use strict; 2 3 use base qw( Plagger::Plugin::Subscription::Bookmarks ); 3 4 trunk/plagger/lib/Plagger/Plugin/Subscription/Bookmarks/Mozilla.pm
r998 r1588 1 1 package Plagger::Plugin::Subscription::Bookmarks::Mozilla; 2 use strict; 2 3 use base qw( Plagger::Plugin::Subscription::XPath ); 3 4 trunk/plagger/lib/Plagger/Plugin/Subscription/Bookmarks/Safari.pm
r1488 r1588 1 1 package Plagger::Plugin::Subscription::Bookmarks::Safari; 2 use strict; 2 3 use base qw( Plagger::Plugin::Subscription::Bookmarks ); 3 4 trunk/plagger/lib/Plagger/Rule/Always.pm
r78 r1588 1 1 package Plagger::Rule::Always; 2 use strict; 2 3 use base qw( Plagger::Rule ); 3 4 trunk/plagger/lib/Plagger/Walker.pm
r1528 r1588 19 19 } 20 20 21 sub apply($&;@) { 21 sub apply($&;@) { ## no critic 22 22 my $self = shift; 23 23 my $code = shift;
