Changeset 1583

Timestamp:

08/24/06 16:12:47

Author:

miyagawa

Message:

Filter::TruePermalink?: remove redirectors.yaml. Instead introduced 'follow_redirect' config which defaults to 1, to check redirection by issuing GET

Files:

• trunk/plagger/assets/plugins/Filter-TruePermalink/redirectors.yaml (deleted)
• trunk/plagger/lib/Plagger/Plugin/Filter/TruePermalink.pm (modified) (6 diffs)
• trunk/plagger/t/plugins/Filter-TruePermalink/oreilly.t (modified) (1 diff)
• trunk/plagger/t/plugins/Filter-TruePermalink/redirect.t (added)

trunk/plagger/lib/Plagger/Plugin/Filter/TruePermalink.pm

@@ -12 +12 @@
-    my $self = shift;
-    $self->SUPER::init(@_);
+    $self->conf->{follow_redirect} = 1 unless exists $self->conf->{follow_redirect};
-    $self->load_plugins;
-}
@@ -32 +33 @@
-    my $data = YAML::LoadFile($file);
-    if (ref($data) eq 'ARRAY') {
-push @{$self->{redirectors}}, { follow_link => "^(?:" . join("|", @$data) . ")" };
+# redirectors.yaml ... make it backward compatible to ignore
-    } else {
-        push @{$self->{plugins}}, $data;
@@ -99 +100 @@
-    }
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
-        }
-    }
@@ -127 +123 @@
-        "redirector:$link",
-        sub {
+            Plagger->context->log(debug => "Issuing GET to $link to follow redirects");
-            my $ua  = Plagger::UserAgent->new;
-            my $res = $ua->simple_request( HTTP::Request->new(GET => $link) );
@@ -137 +134 @@
-    );
-
-ing redirection of $link:
+ed redirection of $link =>
-
-    return $url;
@@ -165 +162 @@
-tries to rewrite url of them.
-
+=head1 CONFIG
+
+=over 4
+
+=item follow_redirect
+
+If set to 1, this plugin issues GET request to entry permalinks to see
+if the server returns 301 or 302 redirect to other URL. Defaults to 1.
+
+=back
+
-=head1 PATTERN FILES
-

trunk/plagger/t/plugins/Filter-TruePermalink/oreilly.t

@@ -1 +1 @@
-use t::TestPlagger;
-
+test_requires_network;
-plan 'no_plan';
-run_eval_expected;